Skip to content

gh-74232: Adds note about csv quoting of booleans#134422

Closed
aterrel wants to merge 2 commits into
python:mainfrom
aterrel:gh-74232-doc-csv-writing-true
Closed

gh-74232: Adds note about csv quoting of booleans#134422
aterrel wants to merge 2 commits into
python:mainfrom
aterrel:gh-74232-doc-csv-writing-true

Conversation

@aterrel

@aterrel aterrel commented May 21, 2025

Copy link
Copy Markdown

Comment thread Doc/library/csv.rst Outdated

Instructs :class:`reader` objects to convert all non-quoted fields to type *float*.

```True``` and ```False``` are numeric types in Python so using this option will

@Yzi-Li Yzi-Li May 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```True``` and ```False``` are numeric types in Python so using this option will
``True`` and ``False`` are numeric types in Python so using this option will

```True``` is markdown syntax, it should be ``True`` in RST documentation.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will update.

@aterrel aterrel requested a review from Yzi-Li May 31, 2025 02:50

@Yzi-Li Yzi-Li left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @serhiy-storchaka is interested in this.

@serhiy-storchaka

Copy link
Copy Markdown
Member

The issues is not only with booleans, and not only with QUOTE_NONNUMERIC. I created other PR #134963.

@aterrel

aterrel commented Jun 1, 2025

Copy link
Copy Markdown
Author

@serhiy-storchaka okay I was just resolving the one issue. I'll close this pr.

@aterrel aterrel closed this Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants